Skip to content

vendor: github.com/docker/docker v28.0.0-rc.2#5838

Merged
thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah:bump_engine
Feb 18, 2025
Merged

vendor: github.com/docker/docker v28.0.0-rc.2#5838
thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah:bump_engine

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

no diff; same commit, but tagged;

moby/moby@57d4d23...v28.0.0-rc.2

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

no diff; same commit, but tagged;

moby/moby@57d4d23...v28.0.0-rc.2

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.16%. Comparing base (bfd49b1) to head (1369019).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5838      +/-   ##
==========================================
+ Coverage   58.78%   59.16%   +0.38%     
==========================================
  Files         349      352       +3     
  Lines       29556    29567      +11     
==========================================
+ Hits        17374    17493     +119     
+ Misses      11198    11092     -106     
+ Partials      984      982       -2     

@thaJeztah
Copy link
Copy Markdown
Member Author

Still flaky 😂

--- FAIL: TestConnectAndWait (0.00s)
    --- FAIL: TestConnectAndWait/connect_goroutine_exits_after_EOF (0.00s)
        socket_test.go:190: assertion failed: 7 (int) != 6 (numGoroutines + 1 int)
--- FAIL: TestConnectAndWait (0.00s)
    --- FAIL: TestConnectAndWait/connect_goroutine_exits_after_EOF (0.00s)
        socket_test.go:190: assertion failed: 7 (int) != 6 (numGoroutines + 1 int)

@thaJeztah thaJeztah merged commit a8f8886 into docker:master Feb 18, 2025
@thaJeztah thaJeztah deleted the bump_engine branch February 18, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants